Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding russian #1855

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Adding russian #1855

wants to merge 1 commit into from

Conversation

nikelborm
Copy link

Problem description

Implementation description

Screenshots

Additional things

@nikelborm
Copy link
Author

Working on #1792

@click0
Copy link

click0 commented Aug 23, 2024

Check the line ending character.
The original repo has CRLF.

@click0
Copy link

click0 commented Sep 3, 2024

I don't see the translation /plugins/builtin/romfs/lang/ru_RU.json

@nikelborm
Copy link
Author

nikelborm commented Sep 3, 2024

I don't see the translation /plugins/builtin/romfs/lang/ru_RU.json

Yes, because it's the biggest file and for that reason I didn't finished it yet and for that reason didn't commit it yet. I (as many people do) have limited free time to work on opensource stuff and this is unpaid work. I want to remind you that this PR is in DRAFT state and you're essentially giving feedback on something I hadn't acknowledged being complete.

@WerWolv
Copy link
Owner

WerWolv commented Sep 15, 2024

Thanks a lot for the effort! I'm happy to merge it once you're ready :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants