fix hex encoded seq num issue when sn is greater than 10 #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Arsh-Sandhu
commented
Mar 28, 2024
Arsh-Sandhu
commented
- fix "too large to encode" hex seq num issue when sn is greater than 10
- add singlesig-rot-bulk.test.ts to test sn greater than 10
- fix "too large to encode" hex seq num issue when sn is greater than 10 - add singlesig-rot-bulk.test.ts to test sn greater than 10 Signed-off-by: arshdeep singh <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #239 +/- ##
==========================================
- Coverage 82.88% 82.76% -0.13%
==========================================
Files 48 47 -1
Lines 4271 4200 -71
Branches 1067 1045 -22
==========================================
- Hits 3540 3476 -64
+ Misses 700 695 -5
+ Partials 31 29 -2 ☔ View full report in Codecov by Sentry. |
|
This was fixed in a conflicting way in development through #216. This has a nice integration test added though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.