Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: Updated How Table Class is Constructed. #203

Merged
merged 4 commits into from
Jan 3, 2024
Merged

Conversation

usernane
Copy link
Member

@usernane usernane commented Jan 3, 2024

No description provided.

Copy link

codecov bot commented Jan 3, 2024

Codecov Report

Attention: 23 lines in your changes are missing coverage. Please review.

Comparison is base (53eeba2) 81.43% compared to head (6b69ce9) 81.26%.
Report is 2 commits behind head on master.

Files Patch % Lines
webfiori/framework/writers/TableClassWriter.php 67.60% 23 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #203      +/-   ##
============================================
- Coverage     81.43%   81.26%   -0.17%     
- Complexity     2323     2350      +27     
============================================
  Files            53       53              
  Lines          7292     7350      +58     
============================================
+ Hits           5938     5973      +35     
- Misses         1354     1377      +23     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

73.6% Duplication on New Code (required ≤ 6%)

See analysis details on SonarCloud

@usernane usernane merged commit 57da7ec into master Jan 3, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant