fix: Fix to Error Detection

closes #91
WebFiori · Oct 28, 2024 · a482f81 · a482f81
1 parent b7cda0c
commit a482f81
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/tests/webfiori/database/tests/mssql/MSSQLQueryBuilderTest.php b/tests/webfiori/database/tests/mssql/MSSQLQueryBuilderTest.php
@@ -715,6 +715,8 @@ public function testInsert05() {
      * @test
      */
     public function testInsert06() {
+        $this->expectException(DatabaseException::class);
+        $this->expectExceptionMessage("207 - Statement(s) could not be prepared: [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Invalid column name 'not_exist'.");
         $schema = new MSSQLTestSchema();
         $q = $schema->table('users_tasks');
         $q->insert([

diff --git a/tests/webfiori/database/tests/mssql/MSSQLTestSchema.php b/tests/webfiori/database/tests/mssql/MSSQLTestSchema.php
@@ -13,7 +13,7 @@
  */
 class MSSQLTestSchema extends Database {
     public function __construct() {
-        parent::__construct(new ConnectionInfo('mssql','sa', '1234567890@Eu', 'testing_db', 'localhost'));
+        parent::__construct(new ConnectionInfo('mssql','sa', '1234567890@Eu', 'testing_db', 'localhost\SQLEXPRESS'));
 
         $table00 = new MSSQLTable('users');
         $table00->setComment('This table is used to hold users info.');

diff --git a/webfiori/database/mssql/MSSQLConnection.php b/webfiori/database/mssql/MSSQLConnection.php
@@ -212,8 +212,8 @@ private function setSqlErr() {
             $lastErr = $allErrs[count($allErrs) - 2];
             $this->sqlState = $lastErr['SQLSTATE'];
             $this->setErrMessage($lastErr['message']);
-        } else if (strpos($lastErr['message'], 'Statement(s) could not be prepared') === true) {
-            $lastErr = $allErrs[count($allErrs) - 1];
+        } else if ($lastErr['SQLSTATE'] == '42000' && $lastErr['code'] == 8180) {
+            $lastErr = $allErrs[count($allErrs) - 2];
             $this->sqlState = $lastErr['SQLSTATE'];
             $this->setErrMessage('Statement(s) could not be prepared: '.$lastErr['message']);
             $this->setErrCode($lastErr['code']);