Rename "addressType" to "address" in the JS API #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
approved these changes
Oct 21, 2024
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Oct 23, 2024
This was renamed in WebAssembly/memory64#92. [email protected] Bug: 41480462 Change-Id: I4b4e5f878ff1ed6e24301dc5b2a2779cb75d7f95 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5953943 Commit-Queue: Clemens Backes <[email protected]> Reviewed-by: Eva Herencsárová <[email protected]> Cr-Commit-Position: refs/heads/main@{#96775}
backes
added a commit
to backes/wasm-spec-memory64
that referenced
this pull request
Oct 23, 2024
"index" was renamed to "address". Without this change, all JS tests generated from the core tests will fail.
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 24, 2024
sbc100
added a commit
to sbc100/emscripten
that referenced
this pull request
Oct 24, 2024
sbc100
added a commit
to emscripten-core/emscripten
that referenced
this pull request
Oct 25, 2024
backes
added a commit
that referenced
this pull request
Oct 25, 2024
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Oct 28, 2024
Import upstream spec tests, in particular including WebAssembly/memory64#91 and WebAssembly/memory64#92. [email protected] Bug: 364917766 Change-Id: I0dd2afab787e1257ee018fdf214bb9173c414572 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5968220 Reviewed-by: Eva Herencsárová <[email protected]> Commit-Queue: Clemens Backes <[email protected]> Cr-Commit-Position: refs/heads/main@{#96851}
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Nov 6, 2024
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Nov 6, 2024
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Nov 6, 2024
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Nov 6, 2024
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Nov 7, 2024
sbc100
added a commit
to WebAssembly/binaryen
that referenced
this pull request
Nov 7, 2024
backes
added a commit
to backes/WebGL
that referenced
this pull request
Nov 29, 2024
1) Use 'address' instead of 'index'; this was a last-minute change, see WebAssembly/memory64#90 and WebAssembly/memory64#92. 2) Only treat RangeError as passing test. Note that the tests were passing before because engines threw a TypeError if the memory descriptor used bigints without specifying {address: 'i64'}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #91 (comment), and the original #67.
Will merge this, then merge #91 with my latest updates.