Rename "index type" to "address type" across the spec #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is very important that you have precisely the correct number of dots. It would be too much work for the computer otherwise.
|
Re-requested review now that the spec interpreter has also been updated. |
rossberg
approved these changes
Oct 17, 2024
Merged
hubot
pushed a commit
to v8/v8
that referenced
this pull request
Oct 21, 2024
This was discussed in WebAssembly/memory64#67 and changed in WebAssembly/memory64#90. This is a pure mechanical renaming of "IndexType" -> "AddressType" and "index_type" -> "address_type". [email protected] Bug: 41480462 Change-Id: Ifb6843ca47d9a48d7aac3d7f64d0f7c7ce4ecec5 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5941627 Commit-Queue: Clemens Backes <[email protected]> Reviewed-by: Eva Herencsárová <[email protected]> Cr-Commit-Position: refs/heads/main@{#96704}
backes
reviewed
Oct 22, 2024
| undefined set(IndexValue index, optional any value); | ||
| readonly attribute IndexValue length; | ||
| AddressValue grow(AddressValue delta, optional any value); | ||
| any get(AddressValue index); |
There was a problem hiding this comment.
Should the parameter name have been updated to address, for get and set?
There was a problem hiding this comment.
Ah, right you are. I'll make a follow-up PR.
There was a problem hiding this comment.
Well, actually, this is arguably fine since the current spec uses "index" (predating memory64) and it's quite clear in context that this is referring to the index of an element. We can rename if we want, but I'm actually somewhat inclined to keep it as is. I'll open an issue just for any final bikeshedding.
backes
added a commit
to backes/wasm-spec-memory64
that referenced
this pull request
Oct 23, 2024
"index" was renamed to "address". Without this change, all JS tests generated from the core tests will fail.
backes
added a commit
that referenced
this pull request
Oct 25, 2024
backes
added a commit
to backes/WebGL
that referenced
this pull request
Nov 29, 2024
1) Use 'address' instead of 'index'; this was a last-minute change, see WebAssembly/memory64#90 and WebAssembly/memory64#92. 2) Only treat RangeError as passing test. Note that the tests were passing before because engines threw a TypeError if the memory descriptor used bigints without specifying {address: 'i64'}.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #67.
Currently draft because I have not yet updated the spec interpreter, but the entire spec (core and JS) should be correct.