Improve tag blocking UI (#1453)

[huntertur]

Closes #1453

Before

After

[charmander]

Thoughts on “Block general and higher” → “Block all ratings”?

[huntertur]

I like "block all ratings"; it sounds less cumbersome than "block general and higher".

My one concern is that, in the (admittedly unlikely) event that a rating lower than General is added to the website, tags which were thought to be blocked on all ratings would suddenly no longer be blocked on all tags, since they would start to appear on pre-General content.

I know the prospect of a pre-General rating getting added is very low, but since it sounds like the rating structure may have changed at least once in the past, I bring this up just in case. If you are OK with this, I will make the change, plus the form field name change suggested in the developer chatroom.

Additional concern while reviewing the text further: I notice that elsewhere on the website, ratings seem to usually be referred to with a capital letter; General and Mature and Explicit are often written as such, but they are lowercase here. If I make this change and your suggested change, the list will look like this:

• Block all ratings
• Block Mature and higher
• Block Explicit only

[charmander]

My one concern is that, in the (admittedly unlikely) event that a rating lower than General is added to the website, tags which were thought to be blocked on all ratings would suddenly no longer be blocked on all tags, since they would start to appear on pre-General content.

Yeah, I’m okay with that. On top of that situation being unlikely, I can’t imagine we would do anything in it other than migrate General+ tag filters to also block the new rating.

For what it’s worth, my main concern was that it would stop matching the column. I think keeping General+ in the column is fine, though.

Additional concern while reviewing the text further: I notice that elsewhere on the website, ratings seem to usually be referred to with a capital letter; General and Mature and Explicit are often written as such, but they are lowercase here.

If I make this change and your suggested change, the list will look like this:

• Block all ratings
• Block Mature and higher
• Block Explicit only

This list looks good. (In general, the site overuses title case, and it’s not necessary here, but I have a slight preference for your suggested version.)

[huntertur]

Pushed new commits to address code review feedback and retain form compatibility.