[WIP] Do not pass root attribute if empty #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uth0#2048) * Delete build assets * Remove es-check from precommit This command fails if `build/` folder is not present. * Copy username to email field for password reset if using custom connection resolver
This reverts commit 7a211f8.
* Revert the revert of the forceAutoHeight property This reverts commit 9b88692. * Add docs to readme
Snyk has created this PR to upgrade blueimp-md5 from 2.18.0 to 2.19.0. See this package in npm: See this project in Snyk: https://app.snyk.io/org/auth0-sdks/project/42f9738c-6d9c-4c05-9008-8b4db478c2af?utm_source=github&utm_medium=referral&page=upgrade-pr
…terprise connection (auth0#2060) * Ensure captcha is completed before sso login * Add test for invalid captcha on enterprise connections
* Guard references to window on module load * Rebuild * Reverse logic of window check in header.jsx
Bumps [validator](https://github.com/validatorjs/validator.js) from 13.6.0 to 13.7.0. - [Release notes](https://github.com/validatorjs/validator.js/releases) - [Changelog](https://github.com/validatorjs/validator.js/blob/master/CHANGELOG.md) - [Commits](validatorjs/validator.js@13.6.0...13.7.0) --- updated-dependencies: - dependency-name: validator dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Snyk has created this PR to upgrade node-fetch from 2.6.5 to 2.6.6. See this package in npm: See this project in Snyk: https://app.snyk.io/org/auth0-sdks/project/42f9738c-6d9c-4c05-9008-8b4db478c2af?utm_source=github&utm_medium=referral&page=upgrade-pr
* Password input now has an ID * Submit button now has an ID
Snyk has created this PR to upgrade auth0-js from 9.16.4 to 9.18.0. See this package in npm: See this project in Snyk: https://app.snyk.io/org/auth0-sdks/project/42f9738c-6d9c-4c05-9008-8b4db478c2af?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: Steve Hobbs <[email protected]>
* Hide captcha for SSO connections in login pane * Add tests for sign-up pane + captcha * Add tests for login pane + captcha * Modify browserstack settings (rolls in auth0#2065) Co-authored-by: Adam Mcgrath <[email protected]>
Snyk has created this PR to upgrade qs from 6.10.1 to 6.10.2. See this package in npm: See this project in Snyk: https://app.snyk.io/org/auth0-sdks/project/42f9738c-6d9c-4c05-9008-8b4db478c2af?utm_source=github&utm_medium=referral&page=upgrade-pr
Snyk has created this PR to upgrade dompurify from 2.3.3 to 2.3.4. See this package in npm: See this project in Snyk: https://app.snyk.io/org/auth0-sdks/project/42f9738c-6d9c-4c05-9008-8b4db478c2af?utm_source=github&utm_medium=referral&page=upgrade-pr Co-authored-by: Steve Hobbs <[email protected]>
Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.14.4 to 1.14.7. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.14.4...v1.14.7) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [engine.io](https://github.com/socketio/engine.io) from 4.1.1 to 4.1.2. - [Release notes](https://github.com/socketio/engine.io/releases) - [Changelog](https://github.com/socketio/engine.io/blob/4.1.2/CHANGELOG.md) - [Commits](socketio/engine.io@4.1.1...4.1.2) --- updated-dependencies: - dependency-name: engine.io dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Steve Hobbs <[email protected]>
Snyk has created this PR to upgrade prop-types from 15.7.2 to 15.8.0. See this package in npm: See this project in Snyk: https://app.snyk.io/org/auth0-sdks/project/42f9738c-6d9c-4c05-9008-8b4db478c2af?utm_source=github&utm_medium=referral&page=upgrade-pr
…85cef377dd6ca1cab
Bumps [log4js](https://github.com/log4js-node/log4js-node) from 6.3.0 to 6.4.0. - [Release notes](https://github.com/log4js-node/log4js-node/releases) - [Changelog](https://github.com/log4js-node/log4js-node/blob/master/CHANGELOG.md) - [Commits](log4js-node/log4js-node@v6.3.0...v6.4.0) --- updated-dependencies: - dependency-name: log4js dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
* Bump auth0-js to 9.18.1 * Bump auth0.js to 9.19.0 * Support passing 'legacySameSiteCookie' to auth0-js * Update snapshots
…#2319) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Steve Hobbs <[email protected]>
…0#2322) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Rita Zerrizuela <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…2329) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…2348) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…o 7.22.3 (auth0#2346) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
upgrade lock.js from 11.27.2 to 12.0.2
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| ? 'https://cdn.' + parts[parts.length - 3] + DOT_AUTH0_DOT_COM | ||
| : AUTH0_US_CDN_URL; | ||
| // prettier-ignore | ||
| if (endsWith(hostname, DOT_AUTH0_DOT_COM)) { // lgtm [js/incomplete-url-substring-sanitization] |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization
| } | ||
|
|
||
| function isObject(arg) { | ||
| return typeof arg === 'object' && arg !== null; |
Check warning
Code scanning / CodeQL
Comparison between inconvertible types
| for (var x = args[i]; i < len; x = args[++i]) { | ||
| if (x === null || !isObject(x)) { | ||
| str += ' ' + x; | ||
| } else if (x !== null) { |
Check notice
Code scanning / CodeQL
Unneeded defensive code
| @@ -1,11 +1,25 @@ | |||
| import React from 'react'; // eslint-disable-line | |||
| import renderer from 'react-test-renderer'; | |||
| import ShallowRenderer from 'react-test-renderer/shallow'; | |||
| import { JavascriptModulesPlugin } from 'webpack'; | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
| @@ -11,14 +33,15 @@ | |||
| } | |||
|
|
|||
| shouldComponentUpdate(nextProps, nextState) { | |||
| const { invalidHint, isValid, value, onChange } = this.props; | |||
| const { invalidHint, isValid, value, disabled, onChange } = this.props; | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
| @@ -11,14 +28,15 @@ | |||
| } | |||
|
|
|||
| shouldComponentUpdate(nextProps, nextState) { | |||
| const { invalidHint, isValid, value, onChange } = this.props; | |||
| const { invalidHint, isValid, value, disabled, onChange } = this.props; | |||
Check notice
Code scanning / CodeQL
Unused variable, import, function or class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API does not accept empty string or null for root attributes, which is a problem when that attribute is optional.
Change made on top of 11.27.2 release commit.