-
-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Json decoding #317
Fix Json decoding #317
Conversation
Hi @HannaTarasevich , thanks for contributing to the project. Please fix the failing test. |
Hi @WasiqB , |
Thanks @WasiqB! |
Sure @HannaTarasevich , once I reach home I will release this change |
Hi @WasiqB @cucumber/cucumber": "^10.0.0" is this fix is supposed to fix that problem too? |
Hi @ymouhat, By the way, @cucumber/cucumber v10 use string literals to attach all the data to json-report now (cucumber/cucumber-js#2260), previously it was encoded. Your data is displayed as encoded, so I'd recommend to debug locally if your JSON-files with reports still contain encoded data. |
HI @HannaTarasevich Thank you for your reply. |
Hi, I have the same issue as @ymouhat - I have to stick to the 3.6.0 version in my reports because of that... |
Hi @pls-spyro |
Just FYI - I hit this issue big time after moving to CucumberJS 10.8.0. The test framework we use is Playwright/Cucumber based with multiple-cucumber-html-reporter being used to make results look pretty and usable. However, as happened to Hanna, it meant all the text logging showed as base64 uck and screenshots/video (video was being attached as text/html within hand-rolled However, updating to 3.6.2 mchr fixes all this nicely - thanks Hanna/Wasiq. But note, only take 3.6.2 IF using attachments and moving to Cucumber v10+. |
Fix #316