-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support EOF data in debug data entries. #583
Conversation
* Removed OS injection in favor of runner.os
* Added a separate test publish step * Removed old job * Fix just in case * Fix * Fix * Added missing run-id * Another fix * Using retention period instead of manual cleanup Potential commit fix * The lock emoji will put reusable workflows at the bottom * Skip experimental executions on PR to avoid failed steps * Fixed experimental check * Fixed PR skip * Fix * Test * Test * Improvements * Test * Better namings * Added emojis
Removed find-pr code
Added VersionSuffix calculation on non master branches
4a2b36f
to
9ce0239
Compare
Fix RsdsDataSegment.Path including null terminator
GitHub Actions Workflow
* Update action.yml * Update reusable-build.yml * Update action.yml * Update action.yml
* Reusable Workflow Secrets Declaration * Update test-and-publish.yml
Tests seem to fail because some debug data entries can have no contents (i.e., size == 0, and thus also pointer/address to raw data == 0, see HelloWorld.exe test binary). We can't really return Two options I see now:
|
UnmanagedPEFileBuilder: Do not duplicate exports and relocations
This pull request adds support for debug data entries located in EOF data, which are valid according to the PE spec:
The file offset is also now preferred over the RVA when the file is not mapped.