Improve symmetry in SignatureComparer

Washi1337 · Nov 17, 2024 · b28cefb · b28cefb
1 parent 72eee24
commit b28cefb
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/AsmResolver.DotNet/Signatures/SignatureComparer.MemberReferences.cs b/src/AsmResolver.DotNet/Signatures/SignatureComparer.MemberReferences.cs
@@ -44,6 +44,8 @@ public bool Equals(IMethodDescriptor? x, IMethodDescriptor? y)
 
             if (x is MethodSpecification specification)
                 return Equals(specification, y as MethodSpecification);
+            else if (y is MethodSpecification)
+                return false;
 
             return x.Name == y.Name
                    && Equals(x.DeclaringType, y.DeclaringType)

diff --git a/src/AsmResolver.DotNet/Signatures/SignatureComparer.TypeSignature.cs b/src/AsmResolver.DotNet/Signatures/SignatureComparer.TypeSignature.cs
@@ -1,7 +1,6 @@
 using System;
 using System.Collections.Generic;
 using System.Linq;
-using AsmResolver.DotNet.Signatures;
 using AsmResolver.PE.DotNet.Metadata.Tables;
 
 namespace AsmResolver.DotNet.Signatures
@@ -31,6 +30,8 @@ public bool Equals(TypeSignature? x, TypeSignature? y)
                 return true;
             if (x is null || y is null)
                 return false;
+            if (x.ElementType != y.ElementType)
+                return false;
 
             switch (x.ElementType)
             {