Code cleanup #2740
Closed
Code cleanup #2740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is pretty much what I consider changes for the sake of changes territory aside from the scavenger file. The magnitude of src/lib changes could create rebase hell for other people working on big things so those would have to wait until 4.3.0-beta1 gets close to a release. |
|
@KJeff01 are we close enough now to beta 1? |
|
Problem is it will cause rebase problems for pastdue, with such work like the terrain normalmapping stuff and whatever. So you are best just keeping the script only changes for the time being. |
|
i saw terrain mapping is now moved to 4.4 and the milestone 4.3 as only 3 items left. now ready to merge? 😅 |
KJeff01
added
the
PR: Limbo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ready for merge