Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sonarqube #1330

Merged
merged 67 commits into from
Mar 13, 2024
Merged

Add sonarqube #1330

merged 67 commits into from
Mar 13, 2024

Conversation

Talhaali00
Copy link
Contributor

No description provided.

Talha Ali added 19 commits February 12, 2024 15:30
add sonar workflow
1f614d1
added build files
59b54b6
commented out unit problematic unit tests
f19b6c5
commented out unit problematic unit tests
d7ebafc
bumped timeout for Relay test
61eac70
fixed publish failure test
6baadb6
added ignore to One client sends unencrypted message, second one rece…
4ba113f 
…ives it
added ignore to RelayerInteractorTest
4f5a448
added ignore to verifyEIP1271Success
e7e704a
changed project name
3a643ff
ignoring screenshot tests to allow Sonar to work
c21b9ae
added ignore on tests that were crashing due to missing Mockk answers
1927734
removed ignoring of Relay tests
35b0e4c
removed ignoring of Cacao tests
44eb8c6
cleaned up jacoco plugin to only look at specific dirs needed for son…
1a314c2 
…ar. Also removed jacoco verification task for now
added sonarqube gradle plugin
909e7f3
added sonarqube to root project and all modules
d135ac3
updated sonar project key
eae02df
added sonarcloud workflow to generate jacoco reports and publish to s…
5a5de03 
…onar
@Talhaali00 Talhaali00 requested review from jakubuid and a team as code owners February 27, 2024 00:00
@Talhaali00
Copy link
Contributor Author

@jakubuid this is ready for review

Talha Ali and others added 17 commits March 7, 2024 15:32
(wip) re-enable notify tests
8f9ef57
fixed NotifyClientInstrumentedAndroidTest
5ad132c
removed commented code
bf929c3
added step to accept licenses
84f6938
updated instrumentation test workflow to use build action before with…
115ec6e 
… new runner
added accepting licenses on composite instrumentation test
0f85295
simplified decode of debug keystore
aecf986
simplified decode of all keystores
90e205b
fixed typo
0ce4dab
added param to instrumented to run on github
5da135e
reverted
c33b05e
trying nexus 6 device
787d7b5
changed runner to ubuntu and added kvm step
650e7f1
@Talhaali00
Merge branch 'develop' into feature/meta/add_sonarqube
5556dee
reverted changes to InboxViewModel
fda1591
ignoring screenshot tests, failing for Sonar only
3cee6cf
ignoring screenshot tests, failing for Sonar only
ac97be7
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
29 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Talhaali00 Talhaali00 requested a review from jakubuid March 12, 2024 04:25
@Talhaali00 Talhaali00 merged commit 2c4688d into develop Mar 13, 2024
9 checks passed
@Talhaali00 Talhaali00 deleted the feature/meta/add_sonarqube branch March 13, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jakubuid jakubuid jakubuid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Talhaali00 @jakubuid