Set lint rules

WalletConnect · Jul 16, 2024 · 15c0af7 · 15c0af7
1 parent d062897
commit 15c0af7
Show file tree

Hide file tree

Showing 14 changed files with 82 additions and 1 deletion.
diff --git a/.github/workflows/ci_android_lint.yml b/.github/workflows/ci_android_lint.yml
@@ -32,6 +32,11 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-gradle-
 
+      - name: Fetch Properties File
+        env:
+          SECRETS_PROPERTIES: ${{ secrets.SECRETS_PROPERTIES }}
+        run: echo $SECRETS_PROPERTIES | base64 --decode > secrets.properties
+
       - name: Grant execute permission for gradlew
         run: chmod +x gradlew
 

diff --git a/core/android/build.gradle.kts b/core/android/build.gradle.kts
@@ -41,6 +41,12 @@ android {
         }
     }
 
+    lint {
+        abortOnError = true
+        ignoreWarnings = true
+        warningsAsErrors = false
+    }
+
     compileOptions {
         sourceCompatibility = jvmVersion
         targetCompatibility = jvmVersion

diff --git a/core/modal/build.gradle.kts b/core/modal/build.gradle.kts
@@ -32,6 +32,12 @@ android {
             proguardFiles(getDefaultProguardFile("proguard-android-optimize.txt"), "${rootDir.path}/gradle/proguard-rules/sdk-rules.pro")
         }
     }
+    lint {
+        abortOnError = true
+        ignoreWarnings = true
+        warningsAsErrors = false
+    }
+
     compileOptions {
         sourceCompatibility = jvmVersion
         targetCompatibility = jvmVersion

diff --git a/product/walletconnectmodal/build.gradle.kts b/product/walletconnectmodal/build.gradle.kts
@@ -38,6 +38,13 @@ android {
             proguardFiles(getDefaultProguardFile("proguard-android-optimize.txt"), "${rootDir.path}/gradle/proguard-rules/sdk-rules.pro")
         }
     }
+
+    lint {
+        abortOnError = true
+        ignoreWarnings = true
+        warningsAsErrors = false
+    }
+
     compileOptions {
         sourceCompatibility = jvmVersion
         targetCompatibility = jvmVersion

diff --git a/product/web3modal/build.gradle.kts b/product/web3modal/build.gradle.kts
@@ -38,6 +38,12 @@ android {
             proguardFiles(getDefaultProguardFile("proguard-android-optimize.txt"), "${rootDir.path}/gradle/proguard-rules/sdk-rules.pro")
         }
     }
+    lint {
+        abortOnError = true
+        ignoreWarnings = true
+        warningsAsErrors = false
+    }
+
     compileOptions {
         sourceCompatibility = jvmVersion
         targetCompatibility = jvmVersion

diff --git a/product/web3wallet/build.gradle.kts b/product/web3wallet/build.gradle.kts
@@ -33,6 +33,12 @@ android {
             proguardFiles(getDefaultProguardFile("proguard-android-optimize.txt"), "${rootDir.path}/gradle/proguard-rules/sdk-rules.pro", "${projectDir}/web3wallet-rules.pro")
         }
     }
+    lint {
+        abortOnError = true
+        ignoreWarnings = true
+        warningsAsErrors = false
+    }
+
     compileOptions {
         sourceCompatibility = jvmVersion
         targetCompatibility = jvmVersion

diff --git a/protocol/auth/build.gradle.kts b/protocol/auth/build.gradle.kts
@@ -47,6 +47,13 @@ android {
         targetCompatibility = jvmVersion
     }
 
+    lint {
+        abortOnError = true
+        ignoreWarnings = true
+        warningsAsErrors = false
+    }
+
+
     kotlinOptions {
         jvmTarget = jvmVersion.toString()
     }

diff --git a/protocol/chat/build.gradle.kts b/protocol/chat/build.gradle.kts
@@ -29,6 +29,12 @@ android {
             proguardFiles(getDefaultProguardFile("proguard-android-optimize.txt"), "${rootDir.path}/gradle/proguard-rules/sdk-rules.pro")
         }
     }
+    lint {
+        abortOnError = true
+        ignoreWarnings = true
+        warningsAsErrors = false
+    }
+
     compileOptions {
         sourceCompatibility = jvmVersion
         targetCompatibility = jvmVersion

diff --git a/protocol/notify/build.gradle.kts b/protocol/notify/build.gradle.kts
@@ -40,6 +40,12 @@ android {
             proguardFiles(getDefaultProguardFile("proguard-android-optimize.txt"), "${rootDir.path}/gradle/proguard-rules/sdk-rules.pro")
         }
     }
+    lint {
+        abortOnError = true
+        ignoreWarnings = true
+        warningsAsErrors = false
+    }
+
     compileOptions {
         sourceCompatibility = jvmVersion
         targetCompatibility = jvmVersion

diff --git a/protocol/sign/build.gradle.kts b/protocol/sign/build.gradle.kts
@@ -54,6 +54,12 @@ android {
         }
     }
 
+    lint {
+        abortOnError = true
+        ignoreWarnings = true
+        warningsAsErrors = false
+    }
+
     compileOptions {
         sourceCompatibility = jvmVersion
         targetCompatibility = jvmVersion

diff --git a/protocol/sign/src/main/kotlin/com/walletconnect/sign/common/validator/SignValidator.kt b/protocol/sign/src/main/kotlin/com/walletconnect/sign/common/validator/SignValidator.kt
@@ -2,6 +2,7 @@
 
 package com.walletconnect.sign.common.validator
 
+import android.annotation.SuppressLint
 import com.walletconnect.android.internal.common.model.Namespace
 import com.walletconnect.android.internal.common.model.RelayProtocolOptions
 import com.walletconnect.android.internal.common.model.SymmetricKey
@@ -211,7 +212,8 @@ internal object SignValidator {
         return true
     }
 
-	private fun allEventsWithChains(namespaces: Map<String, Namespace>): Map<String, List<String>> {
+	@SuppressLint("SuspiciousIndentation")
+    private fun allEventsWithChains(namespaces: Map<String, Namespace>): Map<String, List<String>> {
 		val eventsByChains = mutableMapOf<String, MutableList<String>>()
 		namespaces
 			.filter { (namespaceKey, namespace) -> isNamespaceRegexCompliant(namespaceKey) && namespace.chains != null }

diff --git a/sample/dapp/build.gradle.kts b/sample/dapp/build.gradle.kts
@@ -26,6 +26,12 @@ android {
         buildConfigField("String", "BOM_VERSION", "\"${BOM_VERSION ?: ""}\"")
     }
 
+    lint {
+        abortOnError = true
+        ignoreWarnings = true
+        warningsAsErrors = false
+    }
+
     compileOptions {
         sourceCompatibility = jvmVersion
         targetCompatibility = jvmVersion

diff --git a/sample/modal/build.gradle.kts b/sample/modal/build.gradle.kts
@@ -25,6 +25,12 @@ android {
         buildConfigField("String", "BOM_VERSION", "\"${BOM_VERSION}\"")
     }
 
+    lint {
+        abortOnError = true
+        ignoreWarnings = true
+        warningsAsErrors = false
+    }
+
     compileOptions {
         sourceCompatibility = jvmVersion
         targetCompatibility = jvmVersion

diff --git a/sample/wallet/build.gradle.kts b/sample/wallet/build.gradle.kts
@@ -25,6 +25,12 @@ android {
         buildConfigField("String", "BOM_VERSION", "\"${BOM_VERSION}\"")
     }
 
+    lint {
+        abortOnError = true
+        ignoreWarnings = true
+        warningsAsErrors = false
+    }
+
     compileOptions {
         sourceCompatibility = jvmVersion
         targetCompatibility = jvmVersion