-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/allow ssh #72
base: master
Are you sure you want to change the base?
Conversation
f119cdc
to
04b8b7d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Set $FORCE_SSH under https comments to false
Also make sure that the sed calls are valid git paths
script/install.sh
Outdated
|
||
###################################### | ||
## Set back to https if needed | ||
if [[ $FORCE_SSH == "true" ]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be false
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Si on a set à ssh, je remet à https pour éviter les conflits avec git
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comme ça, le .rosinstal utilise toujours https mais est changé au besoin. Un peut comme du JIT/JAT
script/scrape_config.sh
Outdated
@@ -73,6 +82,14 @@ fi | |||
#rm /tmp/sara_install_ws | |||
|
|||
|
|||
###################################### | |||
## Set back to https if needed | |||
if [[ $FORCE_SSH == "true" ]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every https seems to have the wrong $FORCE_SSH value
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
voir ma réponse au dessu
Ajoute l'utilisation du ssh.
pour tester