Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate shelf HightUnits from device Height if missing. Don't show devices that create invalid shelves in config #85

Merged
merged 2 commits into from
Jul 10, 2024

Conversation

julianstirling
Copy link
Collaborator

@julianstirling julianstirling commented Jul 8, 2024

Pretty self explanatory from title.

  • If HeightUnits isn't set we calculate the it from the height of the unit and the hole spacing.
  • If neither Height or Height units is set then the device isn't listed in the server interface

Relates to #82 - Closes first 2 bullets. Doesn't close the others about special shelves.

@julianstirling
Copy link
Collaborator Author

Hi @jmwright, This is ready for review. It's a small self-contained PR fixing the problem of devices with unbuildable shelves being shown in the interface.

Copy link
Contributor

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Jeremy Wright <[email protected]>
@julianstirling julianstirling merged commit d6fd69b into master Jul 10, 2024
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants