-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split out orchestration #79
Conversation
…orchestration.yml
Hi @jmwright This is the first pass at splitting out most of the orchestration. There is more generalisation to do. And there are especially improvements for how we specify assemblies and sub-assemblies. As much ass possible has been moved into a new settings file CadOrchestration.yml. There is also an "OrchestratorConfigOptions.json" that sets what the server asks. This has to be generated. Currently this is a bit ad hoc, but to improve it I think we really need to move to a framework for the server. Anyway we are back to feature parity with where we were at the start of the merge. I think having the CadOrchestrator will sharpen the mind to trying to make things less specific to the nimble. Now we have a first version, I will start to do Merge requests on the Cad Orchestrator repository too. Testing this branch.The CI tests the static generation For the server you should be able to:
|
@julianstirling Where is |
Hi @jmwright , its in I think that the actual module and folder structure after this split still needs work. But I thought that the work should happen after this PR or it will start becoming unreviewable |
Ok, I got that to work and the server to run. The original server filtered out any hardware that did not have the |
Yeah non-working cnfigs are a big problem in this branch. I can add that filter in in this PR or start working on #82 straight after merge. Up to you |
@julianstirling If #82 is going to happen fairly quickly after this merge, I would not divert time into putting my suggested bandaid on this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few comments. Otherwise it looks good, @julianstirling
Co-authored-by: Jeremy Wright <[email protected]>
In this PR we are splitting out the generic parts of the orchestration and server into a new generic repository called CadOrchestrator
Closes #63, closes #72