-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generic Rendering #101
Generic Rendering #101
Conversation
Do you want me to look at getting the pipeline to run tomorrow? |
I finally got it, thanks. I couldn't get xvfb-run to accept the json, but I finally figured out the incantation of escaped quotes to get it to pass through. Going to need a squash on this merge for sure. |
If you don't want to squash the whole thing you can do |
…lf assembly for the rack, so I put it back
@julianstirling I have fixed the bugs that I introduced, but I still have two issues (the second one is minor).
|
@jmwright Is this ready for review? |
@julianstirling Yes, it's ready. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One suggestion as GitBuilding eats the renders after they are generated. Suggested code tested locally here.
A few comments, but they don't need to delay merging.
Co-authored-by: Julian Stirling <[email protected]>
@julianstirling The build/compile CI Action is giving an error that suggests that I've broken off-screen rendering somehow, and I'm not sure how I did it. I have also somehow broken glb/glTF export, most likely because of the changes I made to
generate_assembly_model
. I'm not super excited about that change (passingrendering_options
around) because it blurs some concepts together, but it was the most direct method I could think of to facilitate the generic rendering mechanism. I'm out of time to work on this right now, and may not be able to get these things fixed before tomorrow.Closes #100