Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Jeremy Wright <[email protected]>
  • Loading branch information
julianstirling and jmwright authored Jul 1, 2024
1 parent 03167cb commit af8accf
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions nimble_orchestration/configuration.py
Original file line number Diff line number Diff line change
Expand Up @@ -231,8 +231,8 @@ def _generate_shelf_list(self):
@property
def assembly_source_file(self):
"""
This is a bit add hoc until we we work out how best to specify assemblies.
Currently we just pass a cad quey file that should pass the assembly def.
This is a bit ad hoc until we we work out how best to specify assemblies.
Currently we just pass a Cadquery file that should pass the assembly def.
We should move away from this with classes for assemblies and sub assemblies.
"""
source = os.path.join(REL_MECH_DIR, "assembly_renderer.py")
Expand Down
8 changes: 4 additions & 4 deletions nimble_orchestration/shelf.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

class Shelf:
"""
A class for all the orchestration information relating to a shelf
A class for all the orchestration information relating to a shelf.
"""
def __init__(self,
assembled_shelf: AssembledComponent,
Expand Down Expand Up @@ -35,21 +35,21 @@ def assembled_shelf(self):
"""
Return the Object describing the assembled shelf (currently this in an empty
shelf in the correct location on the rack).
This is an AssembledComponent
This is an AssembledComponent.
"""
return self._assembled_shelf

@property
def device(self):
"""
Return the Device object for the networking component that sits on this shelf
Return the Device object for the networking component that sits on this shelf.
"""
return self._device

@property
def md(self):
"""
Return the markdown (BuildUp) for the GitBuilding page for assembling this shelf
Return the markdown (BuildUp) for the GitBuilding page for assembling this shelf.
"""
meta_data = {
"Tag": "shelf",
Expand Down

0 comments on commit af8accf

Please sign in to comment.