Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Additional plot functions #15

Merged
merged 6 commits into from
Jan 13, 2023
Merged

Additional plot functions #15

merged 6 commits into from
Jan 13, 2023

Conversation

Rafal-Cichowski
Copy link
Contributor

No description provided.

@majsylw
Copy link
Member

majsylw commented Nov 16, 2022

Please consider also fixing #2
Closes #2

@sdatko
Copy link
Contributor

sdatko commented Dec 5, 2022

The automated tests in this repository were fixed with Pull Request #16
Please rebase your changes on top of current main 😸

@sdatko
Copy link
Contributor

sdatko commented Dec 15, 2022 •
edited
Loading

@Rafal-Cichowski please do the rebase once again (not pull/merge), as this week there were some breaking changes introduced in upstream tox and one more commit was necessary (we are unlucky here, ech)

Never mind, I see @majsylw already did update the branch.

majsylw
majsylw approved these changes Dec 18, 2022
View reviewed changes
Copy link
Member

@majsylw majsylw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks ok ;-) you can also take a look into the documentation (*.rst files) to describe futher developed functions, and in next iteration it would be good to modularize the script into classes ;-)

gnlse/visualization.py Show resolved Hide resolved
gnlse/visualization.py Show resolved Hide resolved
gnlse/gnlse.py Show resolved Hide resolved
@karoltarnowski karoltarnowski mentioned this pull request Jan 13, 2023
Open
@karoltarnowski karoltarnowski merged commit 801e440 into WUST-FOG:main Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karoltarnowski karoltarnowski karoltarnowski left review comments

@majsylw majsylw majsylw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Rafal-Cichowski @majsylw @sdatko @karoltarnowski