Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(DataService): make abstract #2025

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Dec 18, 2024

Changes

This pull request includes several changes to the Angular services and their associated test files, primarily focusing on refactoring and updating dependencies. The most important changes include replacing DataService with specific services for students and teachers, removing unnecessary imports, and updating test configurations.

Refactoring Services:

Updating Test Files:

Dependency Updates:

Miscellaneous Changes:

Test

Application loads and works as before

@hirokiterashima hirokiterashima added this to the Tech Debt 17 -> 16 milestone Dec 18, 2024
@hirokiterashima hirokiterashima self-assigned this Dec 18, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review December 18, 2024 18:54
@hirokiterashima hirokiterashima merged commit 867d8a2 into develop Dec 18, 2024
4 of 5 checks passed
@hirokiterashima hirokiterashima deleted the refactor-DataService-make-abstract branch December 18, 2024 19:07
@hirokiterashima
Copy link
Member Author

🎉 This issue has been resolved in version 5.164.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant