refactor(NodeService): Clean up code #2020
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request focuses on standardizing the naming convention for service variables across multiple files in the project. The changes primarily involve renaming the service variables to use camelCase instead of PascalCase to maintain consistency.
Naming Convention Standardization:
src/assets/wise5/services/gradingNodeService.ts
: RenamedProjectService
toprojectService
ingetNextNodeId
andgetPrevNodeId
methods. [1] [2]src/assets/wise5/services/nodeService.ts
:'use strict';
directive.ConfigService
,ProjectService
, andDataService
toconfigService
,projectService
, anddataService
respectively throughout the file. [1] [2] [3] [4] [5] [6] [7] [8]src/assets/wise5/services/studentNodeService.ts
: RenamedDataService
andProjectService
todataService
andprojectService
respectively ingetNextNodeId
,resolveNextNodeIdFromTransition
, andgetNextNodeIdFromParent
methods. [1] [2] [3]src/assets/wise5/services/teacherNodeService.ts
: RenamedDataService
andProjectService
todataService
andprojectService
respectively ingetNextNodeId
method. Also, formatted the observable declaration for better readability. [1] [2]Test