refactor(GradingStepToolsComponent): extend StepToolsComponent for use in Teacher Tools #2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in Teacher Tools
|
🎉 This issue has been resolved in version 5.163.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request focuses on refactoring and enhancing the
StepToolsComponentby creating a newGradingStepToolsComponentand integrating it into the classroom monitor module. This simplifies the StepToolsComponent by not requiring an extra param and checking to see if mode == "classroomMonitor" in various functions. The changes include updating imports, modifying component logic, and ensuring proper integration and testing.Component Refactor and Integration:
src/app/teacher/classroom-monitor.module.ts: ReplacedStepToolsComponentwithGradingStepToolsComponentin imports and declarations. [1] [2] [3]src/assets/wise5/classroomMonitor/classroomMonitorComponents/grading-step-tools/grading-step-tools.component.ts: CreatedGradingStepToolsComponentextendingStepToolsComponentwith additional logic for grading-specific functionality.src/assets/wise5/classroomMonitor/classroomMonitorComponents/shared/tool-bar/tool-bar.component.html: Updated to usegrading-step-toolsinstead ofstep-tools.Testing:
src/assets/wise5/classroomMonitor/classroomMonitorComponents/grading-step-tools/grading-step-tools.component.spec.ts: Added unit tests forGradingStepToolsComponent.StepToolsComponent Modifications:
src/assets/wise5/common/stepTools/step-tools.component.ts: Refactored to remove classroom monitor-specific logic and make methods protected for extension. [1] [2] [3] [4] [5] [6]Test