refactor(ViewComponentRevisionsComponent): Convert to standalone #2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hirokiterashima
deleted the
convert-ViewComponentRevisions-to-standalone
branch
|
🎉 This issue has been resolved in version 5.163.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request includes several changes to the
ViewComponentRevisionsComponentto improve its modularity and code readability. The most important changes involve refactoring the component to use Angular's standalone components, updating the HTML template syntax, and modifying the TypeScript class to enhance encapsulation and readability.Modularization and Imports:
src/assets/wise5/classroomMonitor/classroomMonitorComponents/view-component-revisions/view-component-revisions.component.ts: Refactored the component to be a standalone component and added necessary Angular Material and Flex Layout modules.HTML Template Updates:
src/assets/wise5/classroomMonitor/classroomMonitorComponents/view-component-revisions/view-component-revisions.component.html: Updated the template syntax to use Angular's*ngForand*ngIfstructural directives. [1] [2] [3]TypeScript Class Enhancements:
src/assets/wise5/classroomMonitor/classroomMonitorComponents/view-component-revisions/view-component-revisions.component.ts: Improved encapsulation by changing class properties toprotectedorprivateand refactored methods for better readability. [1] [2] [3]Removal of Unused Component:
src/app/teacher/classroom-monitor.module.ts: RemovedViewComponentRevisionsComponentfrom the module declarations. [1] [2]Test