refactor(StudentWorkDataExportStrategy, TeacherDataService): move and simplify logic for component state retrieval #2013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… simplify logic for component state retrieval
hirokiterashima
deleted the
refactor-teacherDataService-move-functions-to-StudentWorkDataExportStrategy
branch
|
🎉 This issue has been resolved in version 5.163.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request refactors the
StudentWorkDataExportStrategyclass by moving some methods fromTeacherDataServicetoStudentWorkDataExportStrategy. This change aims to improve the organization and encapsulation of the code.Refactoring and code organization:
src/assets/wise5/classroomMonitor/dataExport/strategies/StudentWorkDataExportStrategy.ts: Moved theinjectRevisionCounterIntoComponentStatesmethod fromTeacherDataServicetoStudentWorkDataExportStrategyand renamed the call to this method accordingly. [1] [2]src/assets/wise5/classroomMonitor/dataExport/strategies/StudentWorkDataExportStrategy.ts: Added a new private methodgetLatestComponentStatesByWorkgroupIdto handle fetching the latest component states, which was previously inTeacherDataService.src/assets/wise5/services/teacherDataService.ts: Removed thegetLatestComponentStatesByWorkgroupIdandinjectRevisionCounterIntoComponentStatesmethods since they have been moved toStudentWorkDataExportStrategy.Test