Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(StudentDataService, VLEParentComponent): simplify logic for node retrieval #2012

Merged

Conversation

hirokiterashima
Copy link
Member

Changes

This pull request includes several changes to improve the StudentDataService and related components. The most important changes involve the removal of the getLatestNodeEnteredEventNodeIdWithExistingNode method, updates to the VLEParentComponent to enhance initialization logic, and the upgrade of the TypeScript target version.

Removal of unnecessary method:

Enhancements to VLEParentComponent:

TypeScript configuration update:

Minor changes:

Test

  • Launching VLE in preview works as before. Try with&without specifying node id.
  • Launching VLE in student works as before. Try fresh student and student with NodeEntered

@hirokiterashima hirokiterashima added this to the Tech Debt 17 -> 16 milestone Nov 27, 2024
@hirokiterashima hirokiterashima self-assigned this Nov 27, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review November 27, 2024 21:20
@hirokiterashima hirokiterashima merged commit 2cc9cea into develop Nov 27, 2024
4 of 5 checks passed
@hirokiterashima hirokiterashima deleted the refactor-VLEParentComponent-getStartingNodeId branch November 27, 2024 21:40
@hirokiterashima
Copy link
Member Author

🎉 This issue has been resolved in version 5.163.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant