Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(PauseScreensMenu): Convert to standalone #2010

Merged
merged 2 commits into from
Nov 27, 2024

Conversation

hirokiterashima
Copy link
Member

Changes

This pull request includes several changes primarily focused on the PauseScreensMenuComponent and its related files. The changes involve refactoring, updating imports, and modifying the component's structure and test files.

Refactoring and Updates to PauseScreensMenuComponent:

  • Removed and re-added PauseScreensMenuComponent in the classroom-monitor.module.ts file to ensure it is correctly imported and used. [1] [2]
  • Updated the HTML template to use a @for loop instead of *ngFor for rendering periods and adjusted the mat-divider syntax. [1] [2]
  • Added several Angular Material modules and other dependencies to the imports of PauseScreensMenuComponent and updated the component to be standalone.
  • Changed the visibility of class properties and methods in PauseScreensMenuComponent from public to protected for better encapsulation.

Test File Adjustments:

  • Removed unnecessary imports and declarations from the top-bar.component.spec.ts test file and ensured PauseScreensMenuComponent is correctly imported. [1] [2]

Miscellaneous:

  • Updated the messages.xlf file to reflect changes in the PauseScreensMenuComponent HTML template.

Test

  • Pause screens works as before

@hirokiterashima hirokiterashima added this to the Standalone Components milestone Nov 27, 2024
@hirokiterashima hirokiterashima self-assigned this Nov 27, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review November 27, 2024 05:53
@hirokiterashima hirokiterashima merged commit 37926a8 into develop Nov 27, 2024
5 checks passed
@hirokiterashima hirokiterashima deleted the convert-PauseScreensMenu-to-standalone branch November 27, 2024 06:08
@hirokiterashima
Copy link
Member Author

🎉 This issue has been resolved in version 5.163.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant