refactor(NodeInfoComponent): Convert to standalone #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This issue has been resolved in version 5.163.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request includes multiple changes primarily focused on refactoring the
NodeInfoComponentand updating its associated files. The main changes involve simplifying the component's structure, updating the template syntax, and modifying the test setup.Refactoring and Simplification:
src/assets/wise5/classroomMonitor/classroomMonitorComponents/shared/node-info/node-info.component.ts: RefactoredNodeInfoComponentto use standalone components, updated imports, and simplified methods for better readability. [1] [2] [3]Template Updates:
src/assets/wise5/classroomMonitor/classroomMonitorComponents/shared/node-info/node-info.component.html: Updated template syntax to use Angular's structural directives and improved readability by replacing*ngIfwith@ifand*ngForwith@for. [1] [2] [3]Test Setup Modifications:
src/app/classroom-monitor/show-node-info-dialog/show-node-info-dialog.component.spec.ts: Removed unused imports and updated the test setup to reflect the changes inNodeInfoComponent. [1] [2]Minor Adjustments:
src/app/classroom-monitor/show-node-info-dialog/show-node-info-dialog.component.html: Minor syntax adjustment for self-closing tag.src/app/teacher/classroom-monitor.module.ts: Corrected the import order ofNodeInfoComponent. [1] [2]Test