refactor(SummaryDisplay): Simplify data service initialization and improve subscription handling #2001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…prove subscription handling
|
🎉 This issue has been resolved in version 5.163.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request includes significant changes to the
StudentSummaryDisplay,SummaryDisplay, andTeacherSummaryDisplaycomponents, primarily focusing on refactoring and code simplification. The most important changes include the removal of redundant methods, making some methods private, and updating the data service handling.Refactoring and code simplification:
src/assets/wise5/directives/student-summary-display/student-summary-display.component.ts: RemovedinitializeDataServicemethod and updated constructor to directly useStudentDataService. MadeinitializeChangeListenersprivate and added type annotations.src/assets/wise5/directives/summary-display/summary-display.component.ts: RemovedinitializeDataServicemethod, moveddataServiceinitialization to constructor, and made several methods private. Updated imports and removed unusedSubscriptionimport. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12]src/assets/wise5/directives/teacher-summary-display/teacher-summary-display.component.ts: RemovedinitializeDataServicemethod and updated constructor to directly useTeacherDataService.Translation and localization updates
Test