Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(WorkgroupComponentGrading): Convert to standalone #1999

Merged

Conversation

hirokiterashima
Copy link
Member

Changes

This pull request includes significant changes to the WorkgroupComponentGradingComponent and its integration within the project. The updates involve refactoring the component to be standalone, modifying its template and TypeScript logic, and updating related HTML files to reflect these changes.

Refactoring and Component Updates:

Integration Updates:

  • src/app/teacher/grading-common.module.ts: Updated the module declarations and imports to accommodate the refactored WorkgroupComponentGradingComponent.
  • Multiple HTML files (milestone-workgroup-item.component.html, workgroup-item.component.html, step-item.component.html): Removed the usage of workgroup-component-grading tags and replaced them with self-closing tags to align with the new component structure. [1] [2] [3] [4]

Translation File Updates:

  • src/messages.xlf: Updated translation unit IDs and context information to reflect changes in the workgroup-component-grading.component.html file.

Test

  • Workgroup grading works as before in the CM. Be sure to test revision and Milestone views.

@hirokiterashima hirokiterashima added this to the Standalone Components milestone Nov 21, 2024
@hirokiterashima hirokiterashima self-assigned this Nov 21, 2024
@hirokiterashima hirokiterashima marked this pull request as ready for review November 21, 2024 20:32
@hirokiterashima hirokiterashima merged commit 89c0157 into develop Nov 21, 2024
5 checks passed
@hirokiterashima hirokiterashima deleted the convert-WorkgroupComponentGrading-to-standalone branch November 21, 2024 20:48
@hirokiterashima
Copy link
Member Author

🎉 This issue has been resolved in version 5.163.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant