feat(NodeAuthoring): Toggle Edit/Preview component #1994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents and set component editing to false
…olders and improved styles
…d on editing state
hirokiterashima
added
the
enhancement
… where choosing asset was exiting edit mode.
…r first component in the node. Remove top Add component button.
- Prevent interaction with preview components - Update preview component hover styles and add tooltip - Update drag and drop placeholder visuals and lock dragging to y-axis - Update component expansion panel styles - Only render concurrent authors display when needed - Give preview components role of button and make keyboard accessible
…rendered Focus causes browser to scroll element into view if necessary.
…e theme highlight class
… authoring - Remove OutsideClickDirective, which was the problem
hirokiterashima
deleted the
node-authoring-ui-changes-toggle-edit-preview-component
branch
|
🎉 This issue has been resolved in version 5.163.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request includes major UI/UX improvements to the step authoring view, allowing users to see a preview of the components when they first open and view, and toggling to the edit view when they click on it. The most important changes are categorized and summarized below:
Module Imports:
ScrollingModuletosrc/app/student-teacher-common.module.tsto enhance scrolling capabilities within the application. [1] [2]Component Updates:
ComponentAuthoringComponentto include new components and event emitters, improving the user interface for editing and previewing components.EditComponentComponentto handle dynamic component creation and destruction, adding new tests to ensure functionality. [1] [2]PreviewComponentComponentto include a disabled state and improved event handling. [1] [2]Removal of Unused Components:
ChooseComponentLocationComponentandPreviewComponentButtonComponentfrom the project, cleaning up the codebase and reducing complexity. [1] [2] [3] [4] [5] [6] [7] [8]Template and Style Changes:
cdkScrollabledirective to the main content area inauthoring-tool.component.htmlto enable better scrolling behavior.concurrent-authors-message.component.htmlto conditionally display the message and added styles for better visual feedback. [1] [2]Test Updates:
ConcurrentAuthorsMessageComponentandAddComponentButtonComponentto reflect changes in component structure and behavior. [1] [2]