refactor(MultipleChoiceComponents): Split to MC[Radio/Checkbox]StudentComponent #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ioStudentComponent and MCCheckoxStudentComponent
hirokiterashima
deleted the
split-MCStudent-to-MCRadioStudent-MCCheckboxStudent
branch
|
🎉 This issue has been resolved in version 5.162.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This pull request refactors the multiple choice components in the
wise5project by introducing new standalone components for radio and checkbox inputs, and updating the main multiple choice component to use these new components. The changes also include making several methods private for better encapsulation.Refactoring multiple choice components:
MultipleChoiceCheckboxStudentComponentandMultipleChoiceRadioStudentComponentas standalone components with their own HTML and TypeScript files. [1] [2] [3] [4]MultipleChoiceStudentComponentto use the new standalone components instead of directly using Angular Material components. [1] [2]Code encapsulation:
MultipleChoiceStudentComponentto private to improve encapsulation. [1] [2]Localization updates:
src/messages.xlfto reflect changes in the HTML structure ofMultipleChoiceStudentComponent. [1] [2] [3]Test