Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Tag): Add tag functionality to personal library #1782

Conversation

geoffreykwan
Copy link
Member

@geoffreykwan geoffreykwan commented May 6, 2024

Changes

  • In personal library added
    • Apply tags button
    • Tags filter
    • Tags displayed in library card
  • In selected tags component, added optional clear filters button

@breity The select tags filter alignment is a little off in the personal library. I tried adding [subscriptSizing]="'dynamic'" to the mat-form-field which fixes the problem in the personal library view but then the alignment is off in the class schedule. Can you look into figuring out a good solution for this?

Test

@geoffreykwan geoffreykwan marked this pull request as ready for review May 7, 2024 15:13
@geoffreykwan geoffreykwan requested a review from breity May 7, 2024 15:17
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks great. I updated the tags filter alignment and some styles.

I found one bug: Checkboxes in the Apply Tags dropdown menu sometimes don't correctly reflect the units that are checked. For example:
Screenshot 2024-05-14 at 12 24 11 PM

@geoffreykwan
Copy link
Member Author

Ah good catch. I've fixed the problem with the apply tags checkbox values not updating correctly.

@geoffreykwan geoffreykwan requested a review from breity May 17, 2024 00:23
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

@geoffreykwan geoffreykwan merged commit 8ef6242 into issue-1686-implement-unit-tagging May 20, 2024
@geoffreykwan geoffreykwan deleted the add-tag-functionality-to-personal-library branch May 20, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants