feat(Multilingual Unit): Authoring and Student #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement switching between languages of the unit content in in student and preview. A language select drop-down will appear if project has locale settings.
Allow authors to select default language and supported languages
- Change i18nId: string to i18n: { id: string, modified: number }
- Rename translation files from project.es.json -> translations.es.json
- Change ProjectLanguageChooser to take in ProjectLocale as input and emit selected Language as output. This will let us reuse this component in the AT. - Move ProjectLanguageChooser to common folder and show it in the AT's TopBarComponent. Update options when author changes them in the Project info view
Create TranslatableInputComponent to show translated text for the current language. Converted some inputs in MC and Match authoring to use TranslatableInputComponent
…s the upper right language drop down options the same even though it should change. Also removes project info/runcode at at-top-bar if we're showing the unit listing view.
…ranslatable input box (#1583) Show default language text hint below the translatable input box. This only appears when the current language is not the default language.
…atableInput (#1585) * Pass in ComponentContent to EditComponentPrompt instead of prompt. This will let us convert the input to TranslatableInput. * Convert EditComponentPrompt input into TranslatableInput
TranslatableInput
In the AT, the tooltip now says "Choose Lanauge to Translate"
…s label (#1588) This helps the translator know to type the translation for the currently-selected language.
…ringComponentModule This will let us import the module and only make changes to it instead of to all the component spec files whenever we need to add new dependencies.
POSTs to an endpoint to save the translations for a locale each time an existing translation text is updated.
…tion (#1618) Pass in required values (label, placeholder) and output (defaultLanguageTextChanged) into the TranslatableInputComponent. This will let us use two inputs and switch between them based on whether we're translating or not. This will allow us to style the input more easily.
ComponentAuthoringModule This will make it easier to add TranslatableTextarea to ComponentAuthoringModule in the future because we won't need to reimport it to the specific component spec files
Modify EditComponentPromptComponent to use this new component
This change set allows translators to save translations for fields that have never been translated into another language before. It requires adding a new i18n field to the default language unit JSON, and using the new i18nId to save the new translation
…only contains default language's text. Before, it contained text & language code, which made it hard to reuse the variable in child classes.
Create TranslatableRichTextareaComponent and use this component to allow translators to translate html components.
…slationText and defaultLanguageText
…cted language on VLE start (#1866)
…r another language that did
hirokiterashima
added
the
enhancement
hirokiterashima
changed the title
…acent input field
|
🎉 This PR is included in version 5.155.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes
Changes
Test
Closes #1513