Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(Peer Chat Export): Add tests and component export strategy tester #1507

Merged
merged 1 commit into from
Nov 7, 2023
Merged

test(Peer Chat Export): Add tests and component export strategy tester #1507

merged 1 commit into from
Nov 7, 2023

Conversation

geoffreykwan
Copy link
Member

Changes

  • Add Peer Chat export tests
  • Create ExportStrategyTester
  • Refactored Discussion export test to use ExportStrategyTester

Test

  • Peer Chat export works
  • Discussion export works

@geoffreykwan geoffreykwan self-assigned this Nov 3, 2023
@geoffreykwan geoffreykwan marked this pull request as ready for review November 3, 2023 22:16
hirokiterashima
hirokiterashima approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoffreykwan geoffreykwan merged commit bca226e into develop Nov 7, 2023
2 checks passed
@geoffreykwan geoffreykwan deleted the peer-chat-export-tests branch November 7, 2023 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@geoffreykwan geoffreykwan

Labels
None yet
Projects
WISE Development 2023-2024
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoffreykwan @hirokiterashima