Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Classroom Status Service): Clean up getNodeCompletion() #1503

Merged
merged 1 commit into from
Nov 1, 2023
Merged

refactor(Classroom Status Service): Clean up getNodeCompletion() #1503

merged 1 commit into from
Nov 1, 2023

Conversation

geoffreykwan
Copy link
Member

Changes

  • Reduced complexity of getNodeCompletion() function
  • Added tests

Test

Make sure the completion is calculated correctly in the "Grade by Step" and "Grade by Team" views.

@geoffreykwan geoffreykwan self-assigned this Nov 1, 2023
@geoffreykwan geoffreykwan marked this pull request as ready for review November 1, 2023 18:45
hirokiterashima
hirokiterashima approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

getNodeCompletion() is easier to follow than before and the completion calculation results look correct in my local testing.

We can address new CC issues created by this change set in a future task.

@geoffreykwan geoffreykwan merged commit 7bdce81 into develop Nov 1, 2023
2 checks passed
@geoffreykwan geoffreykwan deleted the refactor-get-node-completion branch November 1, 2023 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@geoffreykwan geoffreykwan

Labels
None yet
Projects
WISE Development 2023-2024
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoffreykwan @hirokiterashima