Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Classroom Monitor): Grade by Step expand lesson console error #1501

Merged
merged 1 commit into from
Oct 31, 2023
Merged

fix(Classroom Monitor): Grade by Step expand lesson console error #1501

merged 1 commit into from
Oct 31, 2023

Conversation

geoffreykwan
Copy link
Member

@geoffreykwan geoffreykwan commented Oct 30, 2023 •
edited
Loading

Changes

Added call to changeDetectorRef.detectChanges() like we do in other components to prevent ExpressionChangedAfterItHasBeenCheckedError from occurring.

Test

  1. Open the Classroom Monitor for a run
  2. Go to the Grade By Step view
  3. Click on a lesson to expand it. You should not see the error below in the console.
ERROR Error: NG0100: ExpressionChangedAfterItHasBeenCheckedError: Expression has changed after it was checked. Previous value: 'false'. Current value: 'true'. Find more at https://angular.io/errors/NG0100
    at throwErrorIfNoChangesMode (core.mjs:8515:11)
    at bindingUpdated (core.mjs:12843:17)
    at pureFunction1Internal (core.mjs:20614:12)
    at Module.ɵɵpureFunction1 (core.mjs:20411:12)
    at NodeProgressViewComponent_div_0_nav_item_5_Template (node-progress-view.component.html:14:11)

Closes #1500

@geoffreykwan geoffreykwan self-assigned this Oct 30, 2023
@geoffreykwan geoffreykwan marked this pull request as ready for review October 30, 2023 15:38
hirokiterashima
hirokiterashima approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geoffreykwan geoffreykwan merged commit bbd4bb0 into develop Oct 31, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@geoffreykwan geoffreykwan

Labels
None yet
Projects
WISE Development 2023-2024
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(Classroom Monitor): Grade by Step expand lesson console error
2 participants
@geoffreykwan @hirokiterashima