Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(Preview Button): Change mat-icon value to preview #1491

Merged
merged 2 commits into from
Oct 26, 2023
Merged

style(Preview Button): Change mat-icon value to preview #1491

merged 2 commits into from
Oct 26, 2023

Conversation

hirokiterashima
Copy link
Member

Changes

  • Change mat-icon value of preview buttons from "visibility" to "preview"
  • Remove unnecessary attributes from elements

Test

  • Preview unit/step/component icons now shows the preview icon (eye inside a box) throughout the entire application

Closes #1045

@hirokiterashima
style(Preview): Change mat-icon value to preview
cb1bbd4 
Remove unnecessary attributes from elements #1045
@hirokiterashima hirokiterashima added the enhancement New feature of any size or improvement (UI, performance, security) label Oct 25, 2023
@hirokiterashima hirokiterashima self-assigned this Oct 25, 2023
@hirokiterashima hirokiterashima marked this pull request as ready for review October 25, 2023 19:21
geoffreykwan
geoffreykwan requested changes Oct 26, 2023
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. In the Authoring Tool unit list view, there is a preview button that still needs the icon to be changed.

http://localhost:81/teacher/edit/home

  1. In the Authoring Tool, the order of the buttons at the top are info, preview, switch but in the Classroom Monitor the order is info, switch, preview. I think it should be consistent and be ordered info, switch, preview.

@hirokiterashima
Change order buttons in AT
62eee34 
Change pageview -> preview in unit listing icon value

#1045
geoffreykwan
geoffreykwan approved these changes Oct 26, 2023
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit 1335466 into develop Oct 26, 2023
2 checks passed
@hirokiterashima hirokiterashima deleted the issue-1045-change-preview-icon branch October 26, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
enhancement New feature of any size or improvement (UI, performance, security)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change preview icon from visibility to preview
2 participants
@hirokiterashima @geoffreykwan