Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Classroom Monitor): Clean up getStudentProjectCompletion() #1490

Merged
merged 3 commits into from
Oct 26, 2023
Merged

refactor(Classroom Monitor): Clean up getStudentProjectCompletion() #1490

merged 3 commits into from
Oct 26, 2023

Conversation

geoffreykwan
Copy link
Member

@geoffreykwan geoffreykwan commented Oct 25, 2023 •
edited
Loading

Changes

  • Cleaned up getStudentProjectCompletion()
  • When initializing students, only look at workgroups that have a workgroup id
  • Removed getWorkgroupIdsOnNode() function which was no longer used

Test

  • Make sure the Grade By Team view (where it shows all the workgroups) works and shows the unit completion for the workgroups
  • Make sure the workgroup grading view (where it shows just one workgroup) works and shows the completion percentage

@geoffreykwan geoffreykwan self-assigned this Oct 25, 2023
@geoffreykwan geoffreykwan marked this pull request as ready for review October 25, 2023 19:17
hirokiterashima
hirokiterashima approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. See inline comment before merging.

src/assets/wise5/classroomMonitor/student-progress/student-progress.component.ts Outdated
@@ -99,7 +101,7 @@ export class StudentProgressComponent implements OnInit {
* @return object with completed, total, and percent completed (integer between 0 and 100)
*/
private getStudentProjectCompletion(workgroupId: number): any {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this function definition and call this.classroomStatusService.getStudentProjectCompletion(workgroupId) directly in updateTeam()?

@geoffreykwan geoffreykwan merged commit fe3cf2b into develop Oct 26, 2023
2 checks passed
@geoffreykwan geoffreykwan deleted the refactor-get-student-project-completion branch October 26, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hirokiterashima hirokiterashima hirokiterashima approved these changes

Assignees

@geoffreykwan geoffreykwan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoffreykwan @hirokiterashima