Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Authoring): Recovery view does not load when project is broken #1489

Conversation

geoffreykwan
Copy link
Member

Changes

  • Added specific route for the recovery view with its own resolver
  • Removed null check for projectURL because I couldn't find where this would occur

Test

  • Make sure recovery view works when the project is broken. You can break a project by adding a non-existing step node id to the ids array of a group node.
  • Make sure projects load normally in the VLE, Authoring, Classroom Monitor

Closes #1488

@geoffreykwan geoffreykwan self-assigned this Oct 25, 2023
@geoffreykwan geoffreykwan marked this pull request as ready for review October 25, 2023 15:36
@hirokiterashima
Copy link
Member

hirokiterashima commented Oct 25, 2023

Part of the original problem seems to be due to the fact that we're trying to load the unit editing view, which requires a resolver to retrieve the unit (and NOT parse it in the case of recovery).

Should the recovery view even be under the /teacher/edit/unit/:unitId path anymore, or should it be under another path, e.g., /teacher/edit/recovery/:unitId? Would this allow us to avoid the issues? We don't need all the other tools (milestone, info, assets, etc) when we're in the recovery mode, so would it make sense to separate it out?

Copy link
Member

@hirokiterashima hirokiterashima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I think we can clean up the projectService retrieve/parse project sequence a bit in the future. Something feels a bit off about the setProject() function that sets the project and also parses it.

@geoffreykwan geoffreykwan merged commit b02f5f4 into develop Oct 31, 2023
2 checks passed
@geoffreykwan geoffreykwan deleted the issue-1488-recovery-view-does-not-load-when-project-is-broken branch October 31, 2023 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(Authoring): Recovery view does not load when project is broken
2 participants