Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(DiscussionShowWorkComponent): Extract common function to show/hide posts #1485

Merged
merged 1 commit into from
Oct 24, 2023
Merged

refactor(DiscussionShowWorkComponent): Extract common function to show/hide posts #1485

merged 1 commit into from
Oct 24, 2023

Conversation

hirokiterashima
Copy link
Member

Changes

  • Extract common code to flagPost() function to handle hiding/showing posts
  • Rename functions to hidePost() and showPost() and add private/protected modifiers

Test

  • In the CM, the teacher can show/hide comments in the discussion component as before, and it is reflected in the student's view

@hirokiterashima hirokiterashima added this to the Tech Debt 19 -> 18 milestone Oct 24, 2023
@hirokiterashima hirokiterashima self-assigned this Oct 24, 2023
@hirokiterashima hirokiterashima marked this pull request as ready for review October 24, 2023 01:47
geoffreykwan
geoffreykwan approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit fd10107 into develop Oct 24, 2023
2 checks passed
@hirokiterashima hirokiterashima deleted the refactor-discussion-show-hide-posts branch October 24, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
Code Quality
Projects
WISE Development
Status: Done
Milestone
Tech Debt 19 -> 18
Development

Successfully merging this pull request may close these issues.
2 participants
@hirokiterashima @geoffreykwan