refactor(AnnotationService): Move isThereAnyScoreAnnotation() to NodeInfo #1484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also extract common code to getAnnotationByNodeIdComponentId
hirokiterashima
changed the title
geoffreykwan
requested changes
Oct 24, 2023
There was a problem hiding this comment.
If a component has a score or auto score, the Step Info dialog should show a bar graph of the score distribution for the students in the period. Right now it does not show any graph.
I think in NodeInfoComponent.hasScoreAnnotation() you either need to return the value in the some() function or remove the braces.
annotation is found
hirokiterashima
deleted the
refactor-annotation-service-move-isThereAnyScoreAnnotation
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
AnnotationService.isThereAnyScoreAnnotation()toNodeInfoComponent.hasScoreAnnotation()(only place where it's used) and rewrite the body using declarative syntaxAnnotationService.getAnnotationsByNodeIdComponentId()Test