Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Export): Include Question Used column in Peer Chat export #1483

Merged
merged 5 commits into from
Oct 27, 2023

Conversation

geoffreykwan
Copy link
Member

Changes

  • If "Student can select questions to use in Peer Chat" is enabled, include "Question Used" column in the export
  • Now only show either "Prompt" or "Dynamic Prompt" column, not both. Previously we would show both.

Test

  • If "Student can select questions to use in Peer Chat" is enabled, show the "Question Used" column
  • If a student used a question for their response, make sure it shows the question they used in the "Question Used" column
  • If dynamic prompt is enabled, make sure the "Dynamic Prompt" column shows up and the "Prompt" column does not
  • If dynamic prompt is not enabled, make sure the "Prompt" column shows up and the "Dynamic Prompt" column does not

Closes #1482

@geoffreykwan geoffreykwan self-assigned this Oct 20, 2023
@geoffreykwan geoffreykwan marked this pull request as ready for review October 20, 2023 19:28
@geoffreykwan geoffreykwan requested a review from breity October 20, 2023 19:28
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality looks good.

There is some duplication added. One way you could simplify might be to combine each of insert column functions that are very similar into two functions, insertPromptColumns and insertQuestionColumns. So, for example, the logic for each of the 4 separate insert prompt column functions would just go in one (insertPrompColumns). What do you think?

@geoffreykwan geoffreykwan requested a review from breity October 24, 2023 17:54
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

@geoffreykwan geoffreykwan merged commit 5e0b3cb into develop Oct 27, 2023
2 checks passed
@geoffreykwan geoffreykwan deleted the issue-1482-peer-chat-question-used-in-export branch October 27, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

feat(Export): Include Question Used column in Peer Chat export
2 participants