Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Entire Application): Upgrade to Angular 16 #1477

Merged
merged 9 commits into from
Nov 2, 2023
Merged

feat(Entire Application): Upgrade to Angular 16 #1477

merged 9 commits into from
Nov 2, 2023

Conversation

hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Oct 19, 2023 •
edited
Loading

Changes

  • Upgrade Angular from 15 to 16 and related dependencies

Test

  • Everything works and looks the same as before for VLE, Preview, CM, AT, and site

@hirokiterashima hirokiterashima self-assigned this Oct 19, 2023
@hirokiterashima hirokiterashima marked this pull request as ready for review October 19, 2023 02:49
@hirokiterashima
Copy link
Member Author

There are few styling issues that I found so far. @breity can you please take a look?

In Student VLE -> Feedback from teacher box, the arrow is jutting out too much to the left of the box:
Screenshot 2023-10-18 at 6 26 14 PM

In Unit plan view and grade-by-step view, the progress bar has a scroll bar:
Screenshot 2023-10-18 at 6 26 00 PM

@hirokiterashima hirokiterashima changed the title feat(Code): Upgrade to Angular 16 feat(Entire Application): Upgrade to Angular 16 Oct 19, 2023
breity
breity approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I fixed the mentioned styling issues plus some others that I found.

geoffreykwan
geoffreykwan approved these changes Oct 24, 2023
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima
Copy link
Member Author

hirokiterashima commented Oct 31, 2023 •
edited
Loading

Updated to use https://www.npmjs.com/package/@wise-community/angular-password-strength-meter, which works with Angular 16. Also merged in latest from the develop branch. PTAL.

geoffreykwan
geoffreykwan requested changes Nov 1, 2023
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The font in the open response student textarea has changed.

Screenshot 2023-11-01 121635

@hirokiterashima
Copy link
Member Author

hirokiterashima commented Nov 1, 2023 •
edited
Loading

Good catch. This looks like an effect of the changes in the Angular 16 material design library. @breity and I fixed it by adding font styles to the textarea element. Let's look into converting this to using Angular input in a future task. PTAL.

geoffreykwan
geoffreykwan approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit 4f2a1e0 into develop Nov 2, 2023
2 checks passed
@hirokiterashima hirokiterashima deleted the issue-1476-upgrade-to-angular-16 branch November 2, 2023 20:46
@hirokiterashima hirokiterashima mentioned this pull request Nov 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

@breity breity breity approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
build
Projects
WISE Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hirokiterashima @breity @geoffreykwan