Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(NodeIconChooser): Move KI icon chooser option to top #1474

Merged
merged 2 commits into from
Oct 18, 2023
Merged

refactor(NodeIconChooser): Move KI icon chooser option to top #1474

merged 2 commits into from
Oct 18, 2023

Conversation

hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Oct 18, 2023 •
edited
Loading

Notes

  • Please style/edit as you see fit

Changes

  • Move KI icon chooser to the top, and custom icon chooser to the bottom in "Choose an Icon" dialog. We learned this is the preferred order from our user studies.

Test

  • In the node icon chooser dialog, KI icon appears above the custom icon chooser
  • Node icon chooser works as before

@hirokiterashima hirokiterashima added this to the Tech Debt 19 -> 18 milestone Oct 18, 2023
@hirokiterashima hirokiterashima self-assigned this Oct 18, 2023
@hirokiterashima hirokiterashima marked this pull request as ready for review October 18, 2023 00:13
@hirokiterashima hirokiterashima changed the title style(NodeIconChooser): Move KI chooser to top refactor(NodeIconChooser): Move KI chooser to top Oct 18, 2023
@hirokiterashima hirokiterashima changed the title refactor(NodeIconChooser): Move KI chooser to top refactor(NodeIconChooser): Move KI icon chooser option to top Oct 18, 2023
@breity
Change node icon choosers to MatChipListbox
f88f612 
- Uses listbox accessibility pattern and provides keyboard a11y
breity
breity approved these changes Oct 18, 2023
View reviewed changes
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍

I changed the MatChipSet instances to MatChipListbox which provides keyboard accessibility.

@hirokiterashima hirokiterashima merged commit b528bb8 into develop Oct 18, 2023
2 checks passed
@hirokiterashima hirokiterashima deleted the node-icon-chooser-move-ki-to-top branch October 18, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breity breity breity approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
None yet
Projects
WISE Development
Status: Done
Milestone
Tech Debt 19 -> 18
Development

Successfully merging this pull request may close these issues.
2 participants
@hirokiterashima @breity