Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Project Authoring): Clean up template #1473

Merged

Conversation

hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Oct 17, 2023

Changes (mostly in project-authoring.component.html)

  • Aria-label now says "Select step/lesson" instead of node title
  • Remove the 'group0' master root node from consideration in code instead of template
  • Remove unnecessary divs and styles

Test

  • Project editing page looks and works as before, specifically:
    • Shows node icon and title as before for active and inactive lessons/steps
    • Shows pointer for mouse when hovering over node item
    • Scrolls to and highlights newly added step

- Aria-label now says "Select step/lesson" instead of node title
- Put node title inside mat-checkbox so it becomes a label
- Remove the 'group0' master root node from consideration in code
- Remove unnecessary divs
@hirokiterashima hirokiterashima self-assigned this Oct 17, 2023
@hirokiterashima hirokiterashima added this to the Tech Debt 19 -> 18 milestone Oct 17, 2023
@hirokiterashima hirokiterashima marked this pull request as ready for review October 17, 2023 23:44
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly works except now you have to click on the step title text in order to go into the step. Previously you could click anywhere on the colored bar to go into the step.

@hirokiterashima
Copy link
Member Author

Good catch. PTAL.

Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now when you click on the icon or the step title, it checks the checkbox. Before if you clicked on the icon or step title it would open the step.

Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clicking now works like it used to but the steps in "Unused Lessons" and "Unused Steps" now have a newline after the checkbox.

Screenshot 2023-10-20 115353

Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit 4f1e24d into develop Oct 24, 2023
2 checks passed
@hirokiterashima hirokiterashima deleted the clean-up-project-authoring-template-aria-label branch October 24, 2023 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants