-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(Project Authoring): Clean up template #1473
refactor(Project Authoring): Clean up template #1473
Conversation
- Aria-label now says "Select step/lesson" instead of node title - Put node title inside mat-checkbox so it becomes a label - Remove the 'group0' master root node from consideration in code - Remove unnecessary divs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly works except now you have to click on the step title text in order to go into the step. Previously you could click anywhere on the colored bar to go into the step.
Good catch. PTAL. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now when you click on the icon or the step title, it checks the checkbox. Before if you clicked on the icon or step title it would open the step.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Changes (mostly in project-authoring.component.html)
Test