Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(Project Authoring): Clean up template using node-icon-and-title #1471

Merged
merged 2 commits into from
Oct 17, 2023
Merged

refactor(Project Authoring): Clean up template using node-icon-and-title #1471

merged 2 commits into from
Oct 17, 2023

Conversation

hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Oct 16, 2023 •
edited
Loading

Changes

  • Where we used to show node icon and title separately:
    • Use <node-icon-and-title ...> template to reduce duplication
    • Remove surrounding div and move flex attribute(s) and pointer css class to parent element

Test

  • Project editing page
    • Shows node icon and title as before for active and inactive lessons/steps
    • Shows pointer for mouse when hovering over node item

@hirokiterashima hirokiterashima added this to the Tech Debt 19 -> 18 milestone Oct 16, 2023
@hirokiterashima hirokiterashima self-assigned this Oct 16, 2023
@hirokiterashima hirokiterashima marked this pull request as ready for review October 16, 2023 21:45
geoffreykwan
geoffreykwan approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit fca93f9 into develop Oct 17, 2023
2 checks passed
@hirokiterashima hirokiterashima deleted the refactor-project-authoring-template-use-node-icon-and-title branch October 17, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@geoffreykwan geoffreykwan geoffreykwan approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
Code Quality
Projects
WISE Development
Status: Done
Milestone
Tech Debt 19 -> 18
Development

Successfully merging this pull request may close these issues.
2 participants
@hirokiterashima @geoffreykwan