Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Add Lesson): Combine Create Your Own and Lesson Structure choices #1468

Merged
merged 5 commits into from
Oct 16, 2023
Merged

feat(Add Lesson): Combine Create Your Own and Lesson Structure choices #1468

merged 5 commits into from
Oct 16, 2023

Conversation

hirokiterashima
Copy link
Member

Notes

  • @breity please style as you see fit

Changes

  • Combine Add New Lesson and Add Structure buttons into one and make UX consistent with Add Step flow (Mockup)
  • Move
    • /unit/x/structure/[jigsaw,self-directed-investigation,...] to
    • /unit/x/add-lesson/structure/[jigsaw,self-directed-investigation,...]
  • Remove "Back to Unit List" button from project authoring view

Test

  • Add Lesson view
    • Create Your Own path works as before, including back/cancel buttons
    • Each of the structure authoring paths works as before, including back/cancel buttons
  • Project authoring view no longer shows Back to Unit List button

Closes #1467

@hirokiterashima hirokiterashima self-assigned this Oct 12, 2023
@hirokiterashima hirokiterashima marked this pull request as ready for review October 12, 2023 23:10
@breity
Standardize styles in add lesson/step tasks
d6d2fcf 
Make bottom nav bars sticky, extract common styles
breity
breity approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@breity breity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I standardized some styles for the add step and add lesson components. Also removed unnecessary aria-labels from buttons.

@hirokiterashima hirokiterashima merged commit 3b80c27 into develop Oct 16, 2023
2 checks passed
@hirokiterashima hirokiterashima deleted the issue-1467-add-lesson-combine-create-your-own-and-lesson-structures branch October 16, 2023 22:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breity breity breity approved these changes

Assignees

@hirokiterashima hirokiterashima

Labels
None yet
Projects
WISE Development
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Lesson: Combine Create Your own and Lesson Structures
2 participants
@hirokiterashima @breity