refactor(StudentRunListComponent): Remove duplication #1463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Combine functions to retrieve number of runs based on status - Extract sortByStartTimeDesc()
hirokiterashima
approved these changes
Oct 11, 2023
There was a problem hiding this comment.
LGTM. I added some minor inline code comments to consider before merge. I also realize that we can now write getRunTotal() declaratively (e.g., this.filteredRuns.filter(...).length)), which will make the code even easier to read, but we can address this at a later time if you'd like.
src/app/domain/run.spec.ts
Outdated
| @@ -1,14 +1,14 @@ | |||
| import { waitForAsync } from '@angular/core/testing'; | |||
| import { Run } from './run'; | |||
| import { title } from 'process'; | |||
There was a problem hiding this comment.
Unused, remove?
Suggested change
| import { title } from 'process'; | |
| import { title } from 'process'; |
src/app/domain/run.spec.ts
Outdated
| runList = [run2, run3, run]; | ||
| runList.sort(sortByRunStartTimeDesc); | ||
| }); | ||
| it('should sort runs by start date', async () => { |
There was a problem hiding this comment.
Remove async and "should"?
Suggested change
| it('should sort runs by start date', async () => { | |
| it('sorts runs by start date', () => { |
| } | ||
|
|
||
| scheduledTotal(): number { | ||
| getRunTotal(type: 'isActive' | 'isScheduled'): number { |
There was a problem hiding this comment.
Suggested change
| getRunTotal(type: 'isActive' | 'isScheduled'): number { | |
| protected getRunTotal(type: 'isActive' | 'isScheduled'): number { |
| } | ||
|
|
||
| scheduledTotal(): number { | ||
| getRunTotal(type: 'isActive' | 'isScheduled'): number { | ||
| let total = 0; | ||
| const now = this.configService.getCurrentServerTime(); | ||
| for (let run of this.filteredRuns) { |
There was a problem hiding this comment.
Suggested change
| for (let run of this.filteredRuns) { | |
| for (const run of this.filteredRuns) { |
|
@hirokiterashima Thanks, I updated with your suggestions and wrote |
breity
deleted the
refactor-student-run-list-component-remove-duplication
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Test