Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Annotation): Create Annotation class #1461

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

hirokiterashima
Copy link
Member

@hirokiterashima hirokiterashima commented Oct 10, 2023

Changes

  • Create Annotation class and type variables as Annotation instead of any on some (not all yet) variables where appropriate
  • Remove extra wrapper { annotation: annotation } that is sent around in observables and pass in Annotation directly
  • Add private modifiers and function return types
  • Fix yoda expressions and remove unnecessary code

Test

  • These annotations are sent, retrieved and displayed correctly as before:
    • Teacher -> Student annotations (score, comments)
    • Student -> Teacher annotations (C-rater auto-score values in node/student grading views)
    • C-rater auto-feedback text for students

Remove extra wrapper { annotation: annotation } that is sent around in
observables
@hirokiterashima hirokiterashima added this to the Tech Debt 19 -> 18 milestone Oct 10, 2023
@hirokiterashima hirokiterashima self-assigned this Oct 10, 2023
@hirokiterashima hirokiterashima marked this pull request as ready for review October 10, 2023 22:25
Copy link
Member

@geoffreykwan geoffreykwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@hirokiterashima hirokiterashima merged commit aec29a4 into develop Oct 11, 2023
2 checks passed
@hirokiterashima hirokiterashima deleted the create-annotation-class branch October 11, 2023 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants